jekyll-feed
jekyll-feed copied to clipboard
jekyll
Site author does not utilize author reference
Going through lib/feed.xml I noticed it generates the feed's main author tag only from author data set in the main config. Would there be any benefit to adding support for using data in a _data/authors.yml file to reduce the duplication of data that could potentially be out of sync?
If it would be worth it I'd be happy to make a pull request.
So, if site.data.authors[site.author] exists, use that object for all the values? Yeah, I'm on board with that :+1:
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If you can still reproduce this error on the
3.1-stableor
masterbranch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.
Thank you for all your contributions.
@pathawks I made a potential solution - @benbalter mentioned it would need to get a security audit to run on github servers. Is there anything I can do to move it along?
I understand you're all very busy, but I'm happy to keep making contributions and doing the work if I could get some direction.
@GarthDB Thank you for contributing! jekyll-authors looks very nice. The solution @pathawks mentioned above would be as simple as modifying the liquid in this plugin, which introduces no security worries and can be deployed to GitHub's servers without a strict security review. Brand new plugins are much more difficult to integrate as our security team is limited and Pages is one of many products they handle. There are other things we have to consider, too, like Product fit, Support & Documentation.
My advice would be to submit a PR to this plugin (and others who might benefit from this). These plugins are already approved so it's much easier to update them than to add another plugin. 😄
@parkr thanks for the advice. The idea behind the jekyll-authors is that right now jekyll-feed and jekyll-seo-tag handle the author data differently. On top of that everyone that has a multiple-author blog is having to write basically the same solution. I understand it would take work and patience, but I think in the long run it would be well worth it.
If I was internal at GitHub I would have some insight as to how to go about it. As an outsider, I throw myself upon the mercy of the court.
This issue has been automatically marked as stale because it has not been commented on for at least one month.
The resources of the Jekyll team are limited, and so we are asking for your help.
If you can still reproduce this error on the 3.1-stable or master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced hooks which provide convenient access points throughout the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be built as a plugin, then please provide more information about why in order to keep this issue open.
Thank you for all your contributions.
I worry we have let Perfect become the enemy of Good here. Let's first modify the plugin to support author references like jekyll-seo-tag, duplicating a lot of the code and doing a lot of crazy logic in Liquid. Then, once we have everything working the way we want and strong tests to ensure that everything is working properly, we can work on extracting some of the logic into a shared plugin.
thanks for the Atom XML template! i noticed that i ended up with invalid Atom because author info is missing and Atom requires it. it seems that author info is only taken from a post?
@GarthDB Could you submit a PR doing all the author logic in the Liquid template, akin to what jekyll-seo-tag does?
This issue has been automatically marked as stale because it has not been commented on for at least two months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.
While it would be great to have standards-based feeds (and maybe in the end even replace the current RSS default with this standards-based version), i think this approach really should be integrated well enough so that it takes all relevant data, and always produces valid Atom.
This issue has been automatically marked as stale because it has not been commented on for at least two months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.
This issue has been automatically marked as stale because it has not been commented on for at least two months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.
This issue has been automatically marked as stale because it has not been commented on for at least two months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.