python-nostr icon indicating copy to clipboard operation
python-nostr copied to clipboard

Request: Can we use the code formatter `black`?

Open callebtc opened this issue 2 years ago • 2 comments

Since there seems to be no convention yet on how to format the code, I would suggest using black (see here).

I wanted to make a PR with that but I don't know how to deal with the pyproject.toml file in this repo. This is the error I get:

$ poetry add black --dev

[tool.poetry] section not found in /Users/cc/git/python-nostr/pyproject.toml

What should I do?

callebtc avatar Feb 08 '23 09:02 callebtc

black would be great!

you need to run “poetry init” first and migrate the dependencies from the requirements file. then “poetry add black —group dev”

can also set up a github action to check code is black formatted. i can help here if the plan is acked.

On Wed, Feb 8, 2023 at 4:05 AM calle @.***> wrote:

Since there seems to be no convention yet on how to format the code, I would suggest using black.

I wanted to make a PR with that but I don't know how to deal with the pyproject.toml file in this repo. This is the error I get:

$ poetry add black --dev

[tool.poetry] section not found in /Users/cc/git/python-nostr/pyproject.toml

What should I do?

— Reply to this email directly, view it on GitHub https://github.com/jeffthibault/python-nostr/issues/59, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGL44HWWXBPRX7GCQAG5MTWWNOXBANCNFSM6AAAAAAUU7OAM4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jeremywhelchel avatar Feb 08 '23 13:02 jeremywhelchel

I need to get familiar with poetry first but I like the idea

jeffthibault avatar Feb 08 '23 14:02 jeffthibault