CollisionDetection icon indicating copy to clipboard operation
CollisionDetection copied to clipboard

Polygon Rectangle missing a "bonus" e

Open dmoa opened this issue 4 years ago • 2 comments
trafficstars

image

The polygon rectangle collision page and the code that goes with it misses out on checking whether a rectangle completely engulfs a polygon.

You could do Rectangle Point for all the points of the polygon, but I think it's worth writing this as a possibility just as polygon point is written as a possibility.

dmoa avatar Jun 25 '21 16:06 dmoa

I've also just noticed that in the source code that polygonPoint checks the same point of a rectangle as many times as there are points of the polygon. Instead, from my understanding, it should run polygonPoint with each of the 4 points of the rectangle.

dmoa avatar Jun 25 '21 16:06 dmoa

Thanks for noticing this! I have a pile of similar (awesome) suggestions I need to get through, so apologies if you don't see a fix immediately – it's coming I promise! :)

jeffThompson avatar Jun 28 '21 12:06 jeffThompson