rescript-apollo-client icon indicating copy to clipboard operation
rescript-apollo-client copied to clipboard

Published 20 hours ago • verified publisher icon jeddeloh

Formats the source code

Open illusionalsagacity opened this issue 1 year ago • 4 comments

I noticed that several files were being re-formatted, IMO it'd be good to run this before some larger PRs start including these formatting changes.

illusionalsagacity avatar Feb 06 '24 04:02 illusionalsagacity

🙃 will have to revisit this and up the CI versions. graphql-ppx has a dev tag that allows rescript 10, but not sure if we ought to do that or just use legacy peer deps

illusionalsagacity avatar Feb 06 '24 04:02 illusionalsagacity

Makes sense. Maybe we should create a feature--rescript-11 branch that you can point future PRs at until it's ready to go into main?

jeddeloh avatar Feb 06 '24 16:02 jeddeloh

Makes sense. Maybe we should create a feature--rescript-11 branch that you can point future PRs at until it's ready to go into main?

Yeah makes sense to me

illusionalsagacity avatar Feb 07 '24 00:02 illusionalsagacity

FYI, I created that branch if you want to point PRs to it.

jeddeloh avatar Feb 09 '24 21:02 jeddeloh