Juliusz Chroboczek

Results 316 comments of Juliusz Chroboczek

How much does it increase latency?

I've implemented a workaround (different than the one you suggest), so this is no longer urgent.

@Sean-Der what happend to that pull request?

> func (pc *PeerConnection) SelectedNetworkType() (t NetworkType, ok bool) { How would the client know when this information becomes invalid and must be recomputed? Can it only change when ICE...

It's easier for the client to query the sender/receiver/transceiver than to keep track of the value last passed to the callback. This is analoguous to the ICE connection state, which...

I've added this to the test: ``` s.SetHostAcceptanceMinWait(0) s.SetSrflxAcceptanceMinWait(0) s.SetPrflxAcceptanceMinWait(0) s.SetRelayAcceptanceMinWait(0) ``` and the timing is similar to the browser's.

I'm not sure what this issue is requesting. There's nothing preventing you from deploying an army of TURN servers, and using a frontend that returns alternate server replies. A cleaner...

I believe this was fixed in 13867664acbcf7a2b55f561fc4ed61b46638438d. However, I agree with @jmattheis that ReadFrom shouldn't be returning a value larger than the packet, since this makes it inconsistent with `PacketConn.ReadFrom`,...

That's debatable. RFC 8489 merely says "See Section 5.4 of [RFC7616] for guidelines.", while RFC 7616 says ``` the server is free to construct the nonce such that it MAY...

So I've looked at it in some more detail, and I see the following problems: * function `readLoop` unconditionally calls `s.log.Errorf`; it should call `Warnf` or `Logf` for errors that...