Sidetabs icon indicating copy to clipboard operation
Sidetabs copied to clipboard

Changing svg.context-properties.content.enabled breaks the sidebar

Open Kitmitsu opened this issue 1 year ago • 3 comments

After installing Simple Tab Groups I went to change svg.context-properties.content.enabled to true to allow light coloured icons to show in dark mode. Restarting firefox after doing this made the sidebar white and unusable. This behaviour still occurs even if Firefox Color is disabled. Any help would be appreciated.

image

Kitmitsu avatar Feb 23 '24 14:02 Kitmitsu

Thanks for the report! I've been unable to reproduce this issue, but I'd like to fix it if I can.

Could I get you to confirm that this issue still occurs when your userChrome.css file is blank, and that this issue is specific to Sidetabs?

jeb5 avatar Feb 24 '24 03:02 jeb5

It doesn't seem to occur with a blank userchrome.css. The only changes in there were the ones to enable the slim sidebar and centre the address bar text. While testing this again with the slim sidebar settings in the userchrome.css, I noticed that sometimes if I restart even with the svg.context setting set to true, the sidebar actually appears normally and not white. But it's really inconsistent.

I installed Bitwarden to see if it has something to do with another sidebar trying to replace the tabs and it completely broke it.

Slim image

Expanded (hover) image

I'm now thinking it might be Simple Tab Groups creating a sidebar too and it sometimes taking priority. I know it used to make a sidebar on Pulse.

Setting up these addons with the userchrome.css changes removed, making sure sidetabs is the selected sidebar from the dropdown and then re-entering the userchrome.css changes seems to fix the issue so I guess the svg option I was changing might have just conveniently seemed to be the issue as it was breaking every time I restarted with it enabled.

Kitmitsu avatar Feb 24 '24 09:02 Kitmitsu

The userChrome.css changes could break other add-ons using the sidebar; I don't think there's any way to only affect a specific add-on using css selectors. I would try clicking Sidetabs in the add-on menu in your toolbar to switch back to Sidetabs when this happens.

jeb5 avatar Feb 25 '24 00:02 jeb5

1 Year later update: I was wrong! After reading #23, I've updated Sidetabs such that the userChrome.css code will only affect Sidetabs, and have no impact on other sidebar extensions.

jeb5 avatar Jan 31 '25 23:01 jeb5