CollapsibleTableSectionViewController icon indicating copy to clipboard operation
CollapsibleTableSectionViewController copied to clipboard

Make TableViewHeader's delegate a weak reference

Open simonbilskyrollins opened this issue 7 years ago • 1 comments

The strong reference to TableViewHeader's delegate turned out to be the source of a memory leak in my app. Changing this reference to weak allows the parent CollapsibleTableViewController to be properly deallocated.

simonbilskyrollins avatar Apr 24 '18 03:04 simonbilskyrollins

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #56   +/-   ##
======================================
  Coverage    96.5%   96.5%           
======================================
  Files           3       3           
  Lines         315     315           
======================================
  Hits          304     304           
  Misses         11      11
Impacted Files Coverage Δ
...ionViewController/CollapsibleTableViewHeader.swift 87.93% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3537a0...b8a335a. Read the comment docs.

codecov-io avatar Apr 24 '18 03:04 codecov-io