switcheroo icon indicating copy to clipboard operation
switcheroo copied to clipboard

Published 20 hours ago • verified publisher icon jdlehman

POC: Use Hooks for SwitcherProvider

Open eightypop opened this issue 6 years ago • 2 comments
trafficstars

the tests are broken because we currently use instance and and we don't have that anymore. I fixed the first one though but manually firing a hashchange.

eightypop avatar Feb 10 '19 18:02 eightypop

Awesome work so far. Yeah, some of the tests around hashchange have been problematic in the past as well. I wonder if jsdom is in a place now where it can handle that without the instance hack we were using before.

jdlehman avatar Feb 10 '19 19:02 jdlehman

yeah it seemed like dispatching the hashchange event worked.

eightypop avatar Feb 10 '19 20:02 eightypop