jsformat-atom icon indicating copy to clipboard operation
jsformat-atom copied to clipboard

Adds a newline after every word

Open cyberwombat opened this issue 11 years ago • 30 comments

Not sure how to describe this. I the latest Atom (I have 0.134.0) the formatter is broken and adds a newline after every word to look like this:

var
  start =
  3;
var
  end =
  3;

I upgraded to latest jsformat-atom without success. My settings have not changed (and I played around with them). Any ideas?

cyberwombat avatar Oct 01 '14 23:10 cyberwombat

You are using v0.7.0 of JSFormat and v0.134.0 of Atom? I don't seem to have this issue with those versions, and I don't think there's any difference across OS'es. I played around with the settings and a bunch of permutations on the snippet you gave me, but I couldn't reproduce. Can you try reinstalling JSFormat if you still have the issue?

ilanbiala avatar Oct 02 '14 00:10 ilanbiala

Tried with same result - tried a bunch of js files and they all act the same way. Weird

cyberwombat avatar Oct 02 '14 01:10 cyberwombat

Did you update to v0.7.1? Does that fix any issues? What OS are you running/

ilanbiala avatar Oct 02 '14 01:10 ilanbiala

Deleted every other packages, reinstalled Atom, restarted - same. I don't appear to have any jsbeautifierrc or any other file in my home dir that seem related. Basically it adds a newline after evert period, parens, and most keywords - doesn't matter the file or location of file. I am on 0.7.1 now

cyberwombat avatar Oct 02 '14 01:10 cyberwombat

Yosemite Beta 4 - could be related - I just downloaded that - this issue was first noticed today

cyberwombat avatar Oct 02 '14 01:10 cyberwombat

I think it has something to do with Yosemite. Sorry about the inconvenience, can you try it when Yosemite is released or if you can download the GM if the build is different. I won't be able to fix it if it is an actual issue once Yosemite is released, but I can report it to the Atom team if it's still an issue. I'm sure they'll notice a difference in the APIs too.

For now, I would suggest turning off JSFormat since it seems to be causing lots of spacing issues, which defeats the purpose of it.

Feel free to report it to the Atom team now and they may fix it if they can determine the cause in Yosemite. I'm using the Cursor class's APIs so you can let them know that's one place to look for the issues.

ilanbiala avatar Oct 02 '14 02:10 ilanbiala

Thanks - posted here https://github.com/atom/atom/issues/3700 - will update as I learn more

cyberwombat avatar Oct 02 '14 03:10 cyberwombat

@cyberwombat still present in the latest updates of JSFormat, Atom, and Yosemite?

ilanbiala avatar Oct 09 '14 00:10 ilanbiala

Yup. Just upgraded everything. AtomBeautify doesn't have that issue btw.

cyberwombat avatar Oct 09 '14 01:10 cyberwombat

Do you know when this issue was introduced? Around what date or what version did you notice this? I can't seem to produce this issue. Can you maybe take a video of you doing it and the settings in your Atom config? I just want to see if maybe you are doing a step in between or maybe Atom says something or something like that.

ilanbiala avatar Oct 09 '14 02:10 ilanbiala

I am not certain - I keep my stuff pretty current - certainly Yosemite and Atom would have been current or just 1 behind. I don't notice the package upgrades as often. It happened 1-2 days before I posted this which is when I upgraded Yosemite. I tried to downgrade Atom to test but I can't find their old versions.

cyberwombat avatar Oct 09 '14 02:10 cyberwombat

I'd say to wait till you have Yosemite - it could certainly be some other thing unique to me that got introduced. I am happy to wait till you can replicate the same software setup.

cyberwombat avatar Oct 09 '14 02:10 cyberwombat

Okay, looks like you'll have to hold out another 2 weeks or so, sorry for the inconvenience.

ilanbiala avatar Oct 09 '14 02:10 ilanbiala

I downloaded and build an older version of Atom (0.130) and set up jsformat 0.3 and have same issue so it seems related to Yosemite as you suspected.

cyberwombat avatar Oct 09 '14 02:10 cyberwombat

Can you try a more recent version of JSFormat like 0.7.0?

ilanbiala avatar Oct 09 '14 02:10 ilanbiala

Any progress on this now that Yosemite is released and available to everyone and possibly less buggy?

ilanbiala avatar Oct 21 '14 21:10 ilanbiala

Nah same issue. Just upgraded to latest jsformat and Atom. I have Yosemite Beta 6 - kinda weird because it's in the app store but the beta 6 came out today - not sure what is up with the app store release. Tried to go to that but it insisted I then reinstall all the betas 2-6 lol.

cyberwombat avatar Oct 21 '14 21:10 cyberwombat

I use Homebrew - could some code you use be part of OSX but overriden by a brew formulae?

cyberwombat avatar Oct 21 '14 21:10 cyberwombat

I don't think so. I think it has something to do with Atom, but I most likely won't be able to tell for sure until I upgrade to Yosemite myself.

ilanbiala avatar Oct 21 '14 21:10 ilanbiala

I have this issue as well

steve-ross avatar Nov 13 '14 17:11 steve-ross

OS and version of JSFormat?

ilanbiala avatar Nov 14 '14 02:11 ilanbiala

Yosemite, JSFormat was the latest version

steve-ross avatar Nov 17 '14 21:11 steve-ross

I can't install Yosemite yet, so I'll only be able to figure out the issue by someone screensharing Atom and running a couple debug statements for me. @steve-ross @cyberwombat would either of you be able to help me out?

ilanbiala avatar Nov 17 '14 22:11 ilanbiala

I'm in no hurry myself as I am using one of the other beautifiers. Happy to wait.

cyberwombat avatar Nov 18 '14 00:11 cyberwombat

@cyberwombat @steve-ross is this still an issue?

ilanbiala avatar Dec 24 '14 19:12 ilanbiala

Not sure... Not using the package anymore

On Wednesday, December 24, 2014, Ilan Biala [email protected] wrote:

@cyberwombat https://github.com/cyberwombat @steve-ross https://github.com/steve-ross is this still an issue?

— Reply to this email directly or view it on GitHub https://github.com/jdc0589/jsformat-atom/issues/31#issuecomment-68070668 .

Oak.Works

Steve Ross O 268-0444

M 344-8113 [IM] [email protected]

steve-ross avatar Dec 24 '14 19:12 steve-ross

@steve-ross just curious why, did you find something better or you don't use Atom or you don't really work with JS anymore?

ilanbiala avatar Dec 24 '14 19:12 ilanbiala

Still does it for me on 0.7.17. I personally stopped using it as well as I use Atom Beautify

cyberwombat avatar Dec 24 '14 22:12 cyberwombat

Hmm weird the last update didn't show right away but still same on 0.7.18

cyberwombat avatar Dec 24 '14 22:12 cyberwombat

I'm using Beautify as well

On Wednesday, December 24, 2014, Yashua [email protected] wrote:

Hmm weird the last update didn't show right away but still same on 0.7.18

— Reply to this email directly or view it on GitHub https://github.com/jdc0589/jsformat-atom/issues/31#issuecomment-68077393 .

Oak.Works

Steve Ross O 268-0444

M 344-8113 [IM] [email protected]

steve-ross avatar Dec 25 '14 18:12 steve-ross