curiosity-driven-exploration-pytorch icon indicating copy to clipboard operation
curiosity-driven-exploration-pytorch copied to clipboard

Env history not managed based on history_size

Open nitinsurya opened this issue 5 years ago • 1 comments
trafficstars

In the following locations of the code:

https://github.com/jcwleo/curiosity-driven-exploration-pytorch/blob/master/envs.py#L188-L189 https://github.com/jcwleo/curiosity-driven-exploration-pytorch/blob/master/envs.py#L286-L287

history is updated assuming the history size is 4. Shouldn't it instead be

self.history[:self.history_size-1, :, :] = self.history[1:, :, :]
self.history[self.history_size-1, :, :] = self.pre_proc(obs)

nitinsurya avatar Sep 19 '20 19:09 nitinsurya

@nitinsurya If you make PR, I'll approve that.

jcwleo avatar Dec 23 '20 03:12 jcwleo