Jen-Chieh Shen

Might it be a good idea to add async tests as well? 🤔

LGTM! I am not sure why the CI is failing, though. 🤔

I thought @kiennq and I were maintainers of this package... 🤔 I like to co-maintain packages with @kiennq since he's one of the elisp developers I trust (we're both maintainers...

[lsp-grammarly]() offers auto installation, so you don't need to install the language server manually. Or you can install it globally: And yes, you do need npm installed! ``` npm i...

FYI, the documentation is in the upstream package lsp-mode; see https://emacs-lsp.github.io/lsp-mode/page/lsp-grammarly/. Feel free to open PRs for improvements! TBH, my documentation and English aren't very good (it's funny and reasonable...

They are simply different types. `csv-separators` is a list of strings, but the separator in this package requires a character. We can use this variable with this package, but I...

Not at all. Feel free to leave this issue open as long as you like! ;)

Thanks for the bug report! I'll look into it when I have time!

Fixed in 2a91a23abc05f26d513a1eb59c3e8cf1f42a0336.

Maybe something like, ```el (defcustom define-it-display-action 'pop-to-buffer "comment here..." :type 'function :group 'define-it) (defun define-it--in-buffer (content) ... (funcall define-it-display-action buf))) ; remove save-selected-window here ``` I think this would be...