Joel Chen

Results 31 comments of Joel Chen
trafficstars

There was a command the server rejected with "bad command line format" error. That caused this handler to be invoked, which remove the command from queue https://github.com/electrode-io/memcache/blob/572495967c2d8f2c7253bace89cf02abc7d97edc/packages/memcache-client/src/lib/connection.ts#L257 but then the...

we are busy updating all our internal components and apps to React 16 in order to take advantage of the new features and the rewritten SSR engine. We will evaluate...

1. please update node.js. Oldest node.js version that's not EOL is 10. 2. Please check `@hapi/inert` and use the version that doesn't require hapi 19+

@connor4312 I am not sure why the windows failure. do you have any pointers?

Thanks for looking into this. For the exists check, I was thinking that if user maps a path by npm scope only, then some package may not have an original...

I looked into the code regarding 1 and 2. Some thoughts and questions: 1. Doing the mapping at `absolutePathToUrl` is more logical. Do we still need to do the path...

thanks. for 2, the case I was thinking is, user could be mapping `node_modules/@myscope` to `packages/myscope`, because we do `startWith` when matching the maps, some packages in `node_modules/@myscope` may not...

@connor4312 I think I may have mistaken this to be working. I tried it again, while the pathMapping code is properly returning the mapped path, vscode is not opening the...

@connor4312 - the breakpoints prediction needs update to account for path mappings also. latest commit fixes that. I've made the changes to piggy back on the sourceMap types a bit....

Hi, thanks for looking into this. I am not sure what to change in `absolutePathToUrlRegexp` to make it work. Can you give me some more details please?