Results 91 comments of Jonathan Channon

If you make a request to `http://localhost:3000/static/lib.js` you'll see the file is trimmed

I didn't see that but will try again. It first came about when an angular client was requesting the js file and it failed to initialise the angular app as...

Just hit this by inspecting the generated code. Why is the default behaviour to throw if not 200 or 204. Seems a very odd decision. I would personally prefer if...

That or just use the full url https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.http.extensions.urihelper.getencodedurl

Actually you won't want that as you'll want relative paths but you could just use the request path?

Yarp! On Thu, 25 Feb 2021 at 19:00, Jason Mitchell wrote: > Yeah you could. I think there are lots of options for this and I'm not > sure that...

As #279 says, you shouldn't be injecting services into your classes constructors, minimal API does not work like that. They should be in the RequestDelegate ```csharp public class MyModule :...

I agree but making a method on an interface abstract static is not going to cause a compiler error if a class implements it and injects something into a constructor...

I've had a play and making the interface have the abstract static method would be an aid to help this. As it's a breaking change I will do this for...

@mariusz96 can you test the latest Carter version, it has an analyzer that warns if you have constructor dependencies 😄