Jacob Hummer
Jacob Hummer
i think i fixed all the lint errors and i made some very basic tests.
📫 pinging previous participants from https://github.com/nodejs/node/issues/29605 @humphd @jasnell @devsnek
its been a month lol 😅 what would be the best way to go about getting feedback/progress on this PR? do i need to @ someone? what should i do?...
ok i moved the stuff into a new file inspect_colors.js as suggested. its right next to the inspect.js. hopefully everything is still 🟢 lol.
``` AssertionError [ERR_ASSERTION]: These builtins are now unexpectedly loaded before pre-execution. If this is intentional, add them to `expected.beforePreExec`. # Note: loading more builtins before pre-execution can lead to startup...
@nodejs/startup 👈 that ping works right? is there someone else who i am supposed to ping? idk. it all broke once i moved it to a new file lol.
ive added it to the test-bootstrap-modules.js safelist to fix the test error
is there anything else i need to do assuming the ci test passes? @nodejs/util @nodejs/startup
GH actions finally all passed ✅
@nodejs/util