jcabi-http icon indicating copy to clipboard operation
jcabi-http copied to clipboard

Published 20 hours ago • verified publisher icon jcabi

Remove MultipartBodyBuilder

Open andreoss opened this issue 4 years ago • 7 comments
trafficstars

MultipartBodyBuilder [1] is replaceable with StringBuilder or ByteBuffer.

[1] https://github.com/jcabi/jcabi-http/blob/771cf34cb1fbe4d68206c1b6e5ab89808ad1d810/src/main/java/com/jcabi/http/request/MultipartBodyBuilder.java

Replace usage of this class and remove it

andreoss avatar Jun 27 '21 05:06 andreoss

@andreoss , I am new in open source contributing can you please tell more detail about this issue like which folder and file do i have to look for the making further changes.

shreegilliorkar avatar Jun 27 '21 10:06 shreegilliorkar

@Shree-Gillorkar Clarified the issue.

andreoss avatar Jun 27 '21 17:06 andreoss

@Shree-Gillorkar Are you going to make a PR for this issue?

andreoss avatar Jul 01 '21 03:07 andreoss

Hey @andreoss, really sorry about late reply. I thought that issue was clarified means solved. I will work on it & make a pull request as soon as possible.

shreegilliorkar avatar Jul 03 '21 03:07 shreegilliorkar

@andreoss, to clarify this issue i have to replace the function call of MultipartBodyBuilder [1] with which function & after that i will have to remove the class or only function call?

shreegilliorkar avatar Jul 03 '21 03:07 shreegilliorkar

@Shree-Gillorkar

  1. Replace usages of MultipartBodyBuilder with StringBuilder
  2. Remove MultipartBodyBuilder

andreoss avatar Jul 03 '21 21:07 andreoss

Hey @andreoss , I made the changes you suggested and made a pull request. Please have a look and suggest me if any changes are required.

shreegilliorkar avatar Jul 04 '21 10:07 shreegilliorkar