Activity Share Button - Refactor Activity Event Elements - [1/a]

[wraeth-eth]

What does this PR do and why?

First stage of adding share button to activity.

This brings all the different elements into a singly unifying component which will later be used to make changes globally to all the components.

No functional code changes here, just refactoring.

Screenshots or screen recordings

NA

Acceptance checklist

• [x] I have evaluated the Approval Guidelines for this PR.
• [x] I have tested this PR in all supported browsers.
• [x] I have tested this PR in dark mode and light mode (if applicable).

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
juice-interface-goerli	✅ Ready (Inspect)	Visit Preview	Nov 25, 2022 at 5:30PM (UTC)
juice-interface-rinkeby	✅ Ready (Inspect)	Visit Preview	Nov 25, 2022 at 5:30PM (UTC)

2 Ignored Deployments

Name	Status	Preview	Updated
juice-interface	⬜️ Ignored (Inspect)		Nov 25, 2022 at 5:30PM (UTC)
juice-interface-theme-demo	⬜️ Ignored (Inspect)		Nov 25, 2022 at 5:30PM (UTC)

[wraeth-eth]

Current dependencies on/for this PR:

• main
  • PR #2566
    • PR #2567
      • PR #1772 👈
        • PR #1895
          • PR #1777
      • PR #2549
        • PR #2568
          • PR #2551
        • PR #2550

This comment was auto-generated by Graphite.

[wraeth-eth]

accidentaly closed

[tomquirk]

@wraeth-eth should we look at getting this over the line?

[wraeth-eth]

For sure @aeolianeth - sorry, been busy with the create stuff

[peripheralist]

hey @wraeth-eth

referencing my feedback here: https://github.com/jbx-protocol/juice-interface/pull/1772#pullrequestreview-1081167558

i've been playing with implementing this and it does feel clean, but ends up further complicating our file structure. we already have event typed objects (DeployedERC20Event, etc) and also event components. adding additional "builder functions" that return a DeployedERC20EventElemProps value just feels overly complicated. let's ignore this for now

i've got work to do for adding the FC events anyway. want me to pick this up where you left it (getting other event elems using this system + maybe other stuff) so i can start working on those too?

[wraeth-eth]

hey @wraeth-eth

referencing my feedback here: #1772 (review)

i've been playing with implementing this and it does feel clean, but ends up further complicating our file structure. we already have event typed objects (DeployedERC20Event, etc) and also event components. adding additional "builder functions" that return a DeployedERC20EventElemProps value just feels overly complicated. let's ignore this for now

i've got work to do for adding the FC events anyway. want me to pick this up where you left it (getting other event elems using this system + maybe other stuff) so i can start working on those too?

sounds good @peripheralist ! go for it