Joseph Weston
Joseph Weston
There's also the question of how to review this MR. It's a lot of code. It may also be that this implementation is inferior to the current LearnerND, and we...
@basnijholt status update / are we blocked?
I would recommend holding the indices in a different datastructure if it is really necessary.
I don't think that that really addresses the issue. If `data` is a public attribute then it should be something that the user can understand and use, especially because right...
_originally posted by Anton Akhmerov ([@anton-akhmerov](https://gitlab.kwant-project.org/anton-akhmerov)) at 2017-07-26T17:24:38.514Z on [GitLab](https://gitlab.kwant-project.org/qt/adaptive/issues/6)_ Removing the milestone because this learner is tricky to implement in a robust way.
_originally posted by Bas Nijholt ([@basnijholt](https://gitlab.kwant-project.org/basnijholt)) at 2018-01-16T13:30:06.039Z on [GitLab](https://gitlab.kwant-project.org/qt/adaptive/issues/6)_ @dvarjas maybe we could discuss your ideas here? :)
_originally posted by Jorn Hoofwijk ([@Jorn](https://gitlab.kwant-project.org/Jorn)) at 2018-09-25T12:11:36.989Z on [GitLab](https://gitlab.kwant-project.org/qt/adaptive/issues/6)_ In what cases would one need this is practice, and do these cases often occur?
## TODO + [ ] use the [deprecated](https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-deprecated) sphinx directive in docstrings + [ ] replaces uses of BlockingRunner in the documentation with Runner + asyncio.run
We should probably add the test, but we can probably wait until #220 is merged, because that will replace LearnerND anyway.
If the test failures are intermittent then it reduces the usefulness of the tests, as we are more likely to disregard an actual failure no?