rabbit_common icon indicating copy to clipboard operation
rabbit_common copied to clipboard

rename mochijson2

Open motobob opened this issue 10 years ago • 3 comments

we should not copy code form other repos with the same name so at least rename it. i do not want to put whole mochiweb as a dependancy intentionally. Otherwise it's not possible to use both rabbit_common and original mochiweb

motobob avatar Apr 20 '15 17:04 motobob

This would be great! Any way this could be merged?

ssawan623 avatar Aug 17 '16 19:08 ssawan623

As mochijson2.erl is a drop in copy-pasta module, any other library using mochi* will fail to generate a release:

ERROR: generate failed while processing /projects/widget/rel:
  {'EXIT',{{badmatch,{error,"Module mochijson2 potentially included by
    two different applications: mochiweb and rabbit_common."}},

Bumping this merge request

dch avatar Dec 21 '16 10:12 dch

Can we get this merged? It's caused a problem for us, and I suspect it'll catch a few other people out as well.

tomtaylor avatar Feb 21 '19 11:02 tomtaylor