jQuery.highlightRegex icon indicating copy to clipboard operation
jQuery.highlightRegex copied to clipboard

Published 20 hours ago • verified publisher icon jbr

Added alternative example

Open julkue opened this issue 9 years ago • 7 comments
trafficstars

Here you go. Closes #19

julkue avatar May 21 '16 07:05 julkue

Ping @jbr

julkue avatar Jul 19 '16 16:07 julkue

@julmot What improvement over the existing demo does the codepen demo offer? Could the existing demo be improved or replaced?

jbr avatar Jul 19 '16 20:07 jbr

I would happily accept changes to https://github.com/jbr/jQuery.highlightRegex/blob/master/index.html if there are features that would improve it

jbr avatar Jul 19 '16 20:07 jbr

Feel free to PR a link to that url to the README

what's wrong now?

julkue avatar Jul 19 '16 21:07 julkue

  1. It is responsive
  2. It is colorized
  3. It allows users to enter custom modifiers
  4. It allows users to specify custom options

julkue avatar Jul 19 '16 21:07 julkue

I realized there was no reason to have two similar examples. I'd like to replace index.html with something like yours, if you think those four improvements would help people get a sense of the plugin.

jbr avatar Jul 19 '16 21:07 jbr

Well, I think both examples give a quick overview and beside of more options the CodePen demo offers a better UX. So the choice is yours :smile:

julkue avatar Jul 20 '16 03:07 julkue