William Casarin

Results 904 comments of William Casarin

its very clear in these examples that the zapper nostrPubkey does not match the pubkey of the zap note... that is what is wrong

the fact that other clients are not catching this means that you can fake zaps on any of those clients. that's insanely bad.

the pubkey of the zap note 9735 has to match the nostrPubkey in the lnurl endpoint. this is how zaps are spec'd ``` // https://getalby.com/.well-known/nostr.json?name=rolznz const nostrPubkey = "15b5cf6cdf4fd1c02f28bcce0f197cafae4c8c7c66a3e2e23af9fe610875315e"; ```...

the nostrPubkey is the pubkey of the lightning node that makes the zaps, not the user's pubkey

do you have an example albyhub lnurl nostrPubkey, I just realized maybe I was just confused by the variable name...

ok I figured out why. our `get_zap_description` function attempts to get the zap_request from the description of the invoice if its not a descriptionhash invoice. I didn't realize you guys...

PR: - [x] https://github.com/damus-io/damus/pull/2404

will push this out to purple testflight soon, I've also cherry-picked it to our next appstore release branch (1.10) which should be out soon

let's fix this after 1.10. it's annoying but this is going to hold up the release for too long.