help icon indicating copy to clipboard operation
help copied to clipboard

PyPI Release: django-polymorphic

Open j-antunes opened this issue 10 months ago • 4 comments
trafficstars

PyPI Release

Hello. Would it be possible to release a new version for this project: https://github.com/jazzband/django-polymorphic Just releasing a version from master would work. No major changes have been done, except bumping the project to be compatible with Django version 4.

If it helps I also created a release here: https://github.com/jazzband/django-polymorphic/releases/tag/v4.0.0

Do let me know what are next steps necessary to get a version out.

Thank you, Joao

j-antunes avatar Dec 26 '24 14:12 j-antunes

Hi @jezdez , I wonder if this would be a good opportunity to show new roadies how to push a release?

blaisep avatar Jan 31 '25 21:01 blaisep

@jezdez @j-antunes my org would be happy to help support django-polymorphic, but we're a bit hesitant to do so given that it feels like it's stalled a bit. Is the goal to still have jazzband assume ownership here? If so, is there a plan for maintainer-like activity, given the current dearth of roadies to help @jezdez out?

Please please don't take this as any sort of negative jab; I fully, fully understand how difficult and time consuming OSS maintainership is, and really appreciate y'all's time on supporting this and the other jazzband packages.

youcandanch avatar Feb 20 '25 20:02 youcandanch

Please hold on this until a decision can be made on #388

I merged one PR after this tag that is necessary for Django 5+ support. I have also reviewed every line of the diff in the tag linked here and everything looks good. The diff is long because of f-string conversion and unittest -> pytest conversion.

bckohan avatar Feb 28 '25 01:02 bckohan

...and there's a group of people willing to help @jezdez , the trick has been coming up with processes to coordinate them.

On Thu, Feb 20, 2025, 3:15 PM Alex Dancho @.***> wrote:

@jezdez https://github.com/jezdez @j-antunes https://github.com/j-antunes my org would be happy to help support django-polymorphic, but we're a bit hesitant to do so given that it feels like it's stalled a bit. Is the goal to still have jazzband assume ownership here? If so, is there a plan for maintainer-like activity, given the current dearth of roadies to help @jezdez https://github.com/jezdez out?

Please please don't take this as any sort of negative jab; I fully, fully understand how difficult and time consuming OSS maintainership is, and really appreciate y'all's time on supporting this and the other jazzband packages.

— Reply to this email directly, view it on GitHub https://github.com/jazzband/help/issues/385#issuecomment-2672583761, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB6D6GTGBFLNZSKHRJG3OL2QYZUVAVCNFSM6AAAAABUHI6QKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGU4DGNZWGE . You are receiving this because you commented.Message ID: @.***> [image: youcandanch]youcandanch left a comment (jazzband/help#385) https://github.com/jazzband/help/issues/385#issuecomment-2672583761

@jezdez https://github.com/jezdez @j-antunes https://github.com/j-antunes my org would be happy to help support django-polymorphic, but we're a bit hesitant to do so given that it feels like it's stalled a bit. Is the goal to still have jazzband assume ownership here? If so, is there a plan for maintainer-like activity, given the current dearth of roadies to help @jezdez https://github.com/jezdez out?

Please please don't take this as any sort of negative jab; I fully, fully understand how difficult and time consuming OSS maintainership is, and really appreciate y'all's time on supporting this and the other jazzband packages.

— Reply to this email directly, view it on GitHub https://github.com/jazzband/help/issues/385#issuecomment-2672583761, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB6D6GTGBFLNZSKHRJG3OL2QYZUVAVCNFSM6AAAAABUHI6QKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZSGU4DGNZWGE . You are receiving this because you commented.Message ID: @.***>

blaisep avatar Feb 28 '25 17:02 blaisep

@jezdez @j-antunes my org would be happy to help support django-polymorphic, but we're a bit hesitant to do so given that it feels like it's stalled a bit. Is the goal to still have jazzband assume ownership here? If so, is there a plan for maintainer-like activity, given the current dearth of roadies to help @jezdez out?

Please please don't take this as any sort of negative jab; I fully, fully understand how difficult and time consuming OSS maintainership is, and really appreciate y'all's time on supporting this and the other jazzband packages.

@youcandanch I have been following the django-polymorphic project for over a year, use it in production, and I have seen how @bckohan has been doing useful updates throughout that time. The main problem we and many other have, is that the pypi release. Many of us have to branch of every once in a while and install directly from that branch. It over-complicates the build for no reason. @bckohan still pushes fixes and has done at least a couple of releases that make django-polymorphic work with the lastest django version (whatever is in Pypi does not work with django 5.x. It would be really really really good if @jezdez or whoever is in charge gives @bckohan pypi deployment permissions. He has commit rights to django-polymorphic, so he is still making changes, but right now there are various people creating their own outdated pypi releases that work with Django 5.x, and that is tbh far more dangerous.

I am willing to help @bckohan if necessary, but I believe the first step to unblock this is to just let him push to pypi. If the process for that is to make a decision on #388, then so be it. Please help with this.

rburhum avatar Apr 06 '25 22:04 rburhum

It seems PyPI issue was closed as done recently https://github.com/pypi/support/issues/4164

Is there anyone can publish this release now? Or it just took too long that PyPI access was given to folks no longer active?

alphatownsman avatar Apr 21 '25 21:04 alphatownsman

@alphatownsman - I just saw this. I did not get any notification, so I am unclear as to what happened or what needs to be done next to be able to release a new version.

j-antunes avatar Apr 27 '25 22:04 j-antunes

Hi @j-antunes, from this GitHub Actions workflow, it looks like releases are being built and published to GitHub, but they aren't being published to PyPI.

So I think the first thing to do is to update that workflow to check that the repository is the jazzband/django-polymorphic repo (see here for an example from another Jazzband project), and then add a step to publish to PyPI (see here for an example).

You may need help from somebody within Jazzband to setup the secret between GitHub and PyPI.

blag avatar Apr 30 '25 01:04 blag

I wonder if this would be a good opportunity to show new roadies how to push a release?

Releasing a new version on PyPI is a matter of a click on the Jazzband website when you are a project lead. You don't need to be a roadie.

Jazzband Releases

  1. Find out who are your project leads at https://jazzband.co/projects/django-polymorphic (spoiler: @bckohan is yours)
  2. Log in (on the Jazzband website, with your GitHub credentials) and scroll down to the Uploads header. Only project leads get it displayed, apparently.
  3. After having uploaded a release via GHA, you'll get a list of unleased versions displayed here. Approve the ones you want to push to PyPI. They will then be uploaded to PyPI and will appear in the Versions section below.
Image

Side Notes

Note that, depending on your GHA configuration, anyone being allowed to push to your repo directly may be able to trigger an upload to your Jazzband project (usually, pushing a Git tag is sufficient; no review is enforced). Releasing by a project lead is hence only a "second line of defense", if you want so, against uncontrolled releases.

As for your project, you may need to adjust the GHA release configuration to look like this:

name: Release
on:
  push:
    tags:
    - '*'
jobs:
  build:
    ...
    steps:
      - ...
      - name: Upload packages to Jazzband
        if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
        uses: pypa/gh-action-pypi-publish@release/v1
        with:
          user: jazzband
          password: ${{ secrets.JAZZBAND_RELEASE_KEY }}
          repository_url: https://jazzband.co/projects/django-polymorphic/upload

See django-analytical or django-user-sessions (as mentioned earlier) for working examples.

bittner avatar Jul 21 '25 11:07 bittner

I just checked and looks like its being pushed to PYPI - https://pypi.org/project/django-polymorphic/ I see there version 4.1 that matches latest released in github

j-antunes avatar Jul 27 '25 20:07 j-antunes