django-push-notifications icon indicating copy to clipboard operation
django-push-notifications copied to clipboard

Incompatible with Python 3.10

Open bertonha opened this issue 4 years ago • 25 comments
trafficstars

This package is not supported on Python 3.10.

Mainly because of the sub dependency hyper (discontinued) is importing Iterable from collection instead of collection.abc

hyper is dependency of apns2

bertonha avatar Oct 06 '21 15:10 bertonha

I am experiencing this issue also.

ImportError: cannot import name 'Iterable' from 'collections'

realsama avatar Oct 13 '21 21:10 realsama

I also have this issue. Are there any plans to support Python 3.10?

koedal avatar Jul 05 '22 21:07 koedal

Quick fix is to patch it like so:

https://github.com/healthvana/h2/commit/d67c6ca10eb7f79c0737c37fdecfe651307a7414

andrewsanchez avatar Sep 01 '22 16:09 andrewsanchez

can we address this? it's been over a year. is there a plan to merge this patch or otherwise?

samirsd avatar Nov 29 '22 16:11 samirsd

Quick fix is to patch it like so:

healthvana/h2@d67c6ca

would you mind explaining how to do this? I'm assuming you'd start by forking django-push-notifications and whatever dependency is problematic and use that...? however I'm not sure where to find the hyper or apns2 packages in this project.

samirsd avatar Nov 29 '22 17:11 samirsd

No, that link shows a monkey-patch, meaning changing a module at runtime. It is not a source patch to be applied to source code.

merwok avatar Nov 29 '22 17:11 merwok

Is this not fixed yet? I'm still facing module not found 'apns2'.

shree-ranga avatar May 21 '23 07:05 shree-ranga

+1

harikvpy avatar Oct 27 '23 05:10 harikvpy

Any updates here?

koedal avatar Oct 27 '23 20:10 koedal

Still seeing this issue on python 3.11

ethanitovitch avatar Dec 27 '23 07:12 ethanitovitch

+1

kmasuhr avatar Jan 20 '24 19:01 kmasuhr

+1

mirodil1 avatar Feb 02 '24 10:02 mirodil1

Still an issue!

ssyberg avatar Mar 13 '24 14:03 ssyberg

I see that, this was opened on Oct 6, 2021, and it's still a issue until now, anyone know of the current state of things? what do we need to support python 3.10+ ?

SaravananRamanathan avatar Apr 22 '24 05:04 SaravananRamanathan

still bug! Is there anyone still maintaining this project?

qx avatar Apr 23 '24 23:04 qx

I believe this is addressed in this PR that I think is almost ready for merge: https://github.com/jazzband/django-push-notifications/pull/696

ssyberg avatar Apr 24 '24 07:04 ssyberg

@ssyberg you can test by yourself, It easy to appear

qx avatar Apr 25 '24 09:04 qx

@ssyberg you can test by yourself, It easy to appear

I don't know what you mean

ssyberg avatar Apr 25 '24 10:04 ssyberg

This is a prone issue and I don't think it's been fixed yet

qx avatar Apr 26 '24 00:04 qx

This is a prone issue and I don't think it's been fixed yet

You mean you don't think that PR addresses it? As I mentioned it hasn't been merged yet.

ssyberg avatar Apr 26 '24 09:04 ssyberg