Adding tests and support for Django 4.2 - 5x and removing EOL versions of python and django

[sebastian-muthwill]

trafficstars

Update python and django versions

• dropped tests for Python <3.7
• dropped tests for Django <4.2
• added tests for Python 3.11, 3.12, 3.13
• added tests for Django >=4.2

This PR addresses the following issues:

• fixes #383
• fixes #390

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.51%. Comparing base (c9d7bf2) to head (9409845).

Files with missing lines	Patch %	Lines
newsletter/__init__.py	66.66%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   86.02%   86.51%   +0.49%     
==========================================
  Files          16       16              
  Lines        1302     1313      +11     
  Branches      138      136       -2     
==========================================
+ Hits         1120     1136      +16     
+ Misses        135      131       -4     
+ Partials       47       46       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[sebastian-muthwill]

Created an issue to get the changes released: https://github.com/jazzband/help/issues/383

[sebastian-muthwill]

I just saw that @dokterbob already released v1.0 to PyPi 🥳 May we have your opinion here as well. I think we should at least merge this PR to master as well to keep master and PyPi version in sync. After that we can discuss if older versions should be supported or not.

[newearthmartin]

Before merging please address the code quality comments I made. Don't leave commented lines and remove the patches for older Django versions.

[adRn-s]

I don't know if I have a strict positioning on the matter, but I'd like to say that a new version of this package that drops support for, say, Django 1.9 is not necessarily wrong. Anyone running Django 1.9 could still use the old django-newsletter version that supports that. This is perfectly normal, expected, and I'd argue even desired (if it makes it easier on manteinance and new developments.)

[newearthmartin]

if it makes it easier on manteinance and new developments.

My suggestion is to drop old versions when they conflict with development. Not before just because. When a new feature requires a higher version of Django, then support can be dropped.

[newearthmartin]

Hi @sebastian-muthwill it seems I forgot about this PR and went and duplicated your efforts on another PR to fix the automated build and tests https://github.com/jazzband/django-newsletter/pull/399

I now get the need to drop the older versions, but it's not just because they are old but because dependencies don't work, for example sorl-thumbanail needs django >= 4.

I did this because I made another PR https://github.com/jazzband/django-newsletter/pull/397 and tests were broken.

Apparently no one cares about this anymore? Nobody is reviewing PRs, so what do you think we should do? Has anyone managed to contact @dokterbob ? Does anyone have rights to approve PRs?

[newearthmartin]

I just joined jazzband and merged this PR

[newearthmartin]

Builds are still broken but I fixed them with https://github.com/jazzband/django-newsletter/pull/399 I'll be merging it later today, I'll wait a little bit in case someone wants to review it before I merge it