django-newsletter icon indicating copy to clipboard operation
django-newsletter copied to clipboard

make_subscriptions misplaced?

Open frennkie opened this issue 5 years ago • 1 comments
trafficstars

The admin interface has an import function for Subscriptions. This uses the function make_subscription from admin_utils.py which makes it unnecessary hard to override the Subscription class (and still use the default admin.py.

I think make_subscription should be a method on Subscription - if you agree I could start a PR.

frennkie avatar Sep 22 '20 20:09 frennkie

Reading this function, I do not think it actually adds value over simply instantiating a Subscription. Feel free to fire a PR removing the function entirely, I think it'll result in the same lines of code, equal readability, less complexity and more adaptability (your purposes, I would expect).

dokterbob avatar Oct 24 '20 19:10 dokterbob