django-newsletter icon indicating copy to clipboard operation
django-newsletter copied to clipboard

Add svg icons from Django 1.9 and use static function

Open claudep opened this issue 9 years ago • 6 comments
trafficstars

Fixes #172.

claudep avatar Nov 03 '16 20:11 claudep

Coverage Status

Coverage increased (+0.03%) to 89.679% when pulling 93c0e570b704a616b08b4f63a86d46b652af791f on claudep:svg_icons into 323dc20ea6f039fba36f478c5aebb9489d099c31 on dokterbob:master.

coveralls avatar Nov 03 '16 20:11 coveralls

Thanks! If wait and submit aren't there yet, perhaps we should not close the SVG ticket altogether.

Any chance we could find equivalent SVG icons for these messages to fully finish this off?

dokterbob avatar Mar 28 '17 10:03 dokterbob

It shouldn't too hard to convert waiting.gif to svg, but submitting.gif is animated, so it's trickier to convert (don't know the status of animated SVG in current browsers).

claudep avatar Mar 28 '17 17:03 claudep

@doctorbob if you are willing to add a non-standard lib, then check out https://loading.io/spinner/ - It would enable you to add a animated svg Icon.

dkdndes avatar Jun 27 '17 10:06 dkdndes

@dkdndes Sounds like overkill to me.

Couldn't we just use one of their spinners and copy it as a direct replacement?

dokterbob avatar Jun 27 '17 13:06 dokterbob

I guess the simplest option would be to add a static SVG spinner image and then use stepped CSS animation to animate it.

dokterbob avatar Jun 27 '17 13:06 dokterbob