Add contact_email instead of overriding [email protected]

[claudep]

trafficstars

Currently, setting up django-newsletter requires some templates being overridden just for setting the contact email in case of errors (replacing [email protected]).

What about adding a new field in the Newsletter model, something like contact_email (or tech_email or ...) which would then dynamically inserted into the templates?

[dokterbob]

That seems like a good solution, go for it!

Try to give coverage though. I’m super glad we got >80% lately and would love to keep it so.

[pakal]

Couldn't it simply be a global django setting ? Similar to SERVER_EMAIL and DEFAULT_FROM_EMAIL, but dedicated to django-newsletter usage ?

[claudep]

As each newsletter might have its own contact email, I'd still privilege a field on the Newsletter model.