django-configurations icon indicating copy to clipboard operation
django-configurations copied to clipboard

Update suggested templates to django 1.11 and django-configuration 2.0

Open alonisser opened this issue 8 years ago • 9 comments
trafficstars

Current Django version is 1.11 and django-configurations is 2.0 while the suggested templates in the docs are upto 1.8 and configurations 1.0

alonisser avatar Oct 16 '17 19:10 alonisser

If a PR along those lines would be desired I can probably push one

alonisser avatar Oct 16 '17 19:10 alonisser

Yes, please do so. IIRC templates are in a separate branch, so watch out.

blueyed avatar Oct 17 '17 23:10 blueyed

@blueyed I've got a branch ready But not sure how to push a PR on this. Pushing to master is probably wrong, and I can't create a new branch on a PR.

How should we proceed from here? Would you create the needed branch ? or should I just send a PR to master?

alonisser avatar Nov 06 '17 22:11 alonisser

You should be able to create a PR for the target branch?!

blueyed avatar Nov 06 '17 22:11 blueyed

The latest would be https://github.com/jazzband/django-configurations/tree/templates/1.8.x however, so yeah - should I/we create 1.11.x base on that first?

blueyed avatar Nov 06 '17 22:11 blueyed

I am not sure it it is worth it (for me) after all - sorry, unsubscribing.

blueyed avatar Nov 06 '17 22:11 blueyed

I can create a pr for the target branch of 1.8.x but i'm supposed to create a new branch for this template (django 1.11 + configurations 2.0) , Since I don't have direct push privilege I need someone with push privilege to create a new templates/1.11.x branch I push to

alonisser avatar Nov 07 '17 07:11 alonisser

@alonisser Do you still have your branch? I've created templates/1.11.x now for you. It is currently identical to the templates/1.8.x branch. You could now place your PR. :grimacing:

bittner avatar Dec 09 '18 23:12 bittner

Oh, it's a pr from a year ago.. I'll take a look

alonisser avatar Dec 13 '18 11:12 alonisser