django-analytical icon indicating copy to clipboard operation
django-analytical copied to clipboard

Heap Integration

Open benje opened this issue 11 years ago • 9 comments
trafficstars

Hey, Thanks for developing django-analytical I think it's great. Would really love it to have a Heap Analytics integration (http://heapanalytics.com) as their service is excellent.

Would be happy to try contribute it myself if somebody wouldn't mind checking over my code? (open source noob!)

Cheers

benje avatar Aug 18 '14 12:08 benje

Hi Ben, sorry for being absent. If you are still interested in contributing, I am happy to go over your code.

jcassee avatar Apr 19 '15 08:04 jcassee

Anyone still interested in this integration?

@jcassee You've mentioned releasing 1.0.0 (in #56). We now have beautiful badges and a test suite covering all Python and Django versions. If no-one desperately needs new services integrated at the moment it's probably a good time to release the first major version.

bittner avatar Aug 24 '15 12:08 bittner

@benje Do you need some assistance in contributing the integration code for Heap analytics?

The integration code from the Heap docs would have to be placed into a Python module, a simple .py file similar to spring_metrics.py. Don't forget to write tests, too. Ideally, you start with them before any other coding.

bittner avatar Sep 24 '15 17:09 bittner

Thanks for the tips @bittner, I will give it a go soon and submit a pull request.

benje avatar Sep 25 '15 10:09 benje

Awesome! :+1: You can now also use the Gitter chat room if you need support. See the README.

bittner avatar Sep 25 '15 11:09 bittner

@benje Still interested in contributing? It's not too difficult to do, almost a copy+paste job. But this is preferably done by someone who actually uses the integration, to confirm it works out well.

bittner avatar May 18 '16 23:05 bittner

I've created a PR for Heap integration. #194

garrettc avatar Jul 16 '21 11:07 garrettc

@bittner Can you review the PR above so it can run through the automated tests please.

garrettc avatar Nov 15 '21 14:11 garrettc

Sorry for the late. I reviewed the PR just now.

bittner avatar Nov 26 '21 00:11 bittner