django-analytical icon indicating copy to clipboard operation
django-analytical copied to clipboard

Remove apparently obsolete setup.cfg

Open bittner opened this issue 3 years ago • 1 comments
trafficstars

The setup.cfg file contains configuration data that used to be read by tools like Tox and Sphinx.

The respective values now appear in pyproject.toml and tox.ini, and it looks like the entire file is hence obsolete.

I'm not 100% sure whether ReadTheDocs reads the file, but I guess building the docs should work just fine without it.

bittner avatar Jul 14 '22 12:07 bittner

Codecov Report

Merging #220 (e596e20) into main (248e04a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          31       31           
  Lines        1344     1344           
=======================================
  Hits         1270     1270           
  Misses         74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 248e04a...e596e20. Read the comment docs.

codecov[bot] avatar Jul 14 '22 12:07 codecov[bot]

Please, anyone, review this PR, so we can merge it!

@jezdez @smithdc1 @PiDelport @jcassee

bittner avatar May 02 '23 07:05 bittner

Thanks Jannis!

bittner avatar May 02 '23 08:05 bittner

@bittner NP, did you see that the CI system isn't working correctly?

jezdez avatar May 02 '23 08:05 jezdez

@bittner NP, did you see that the CI system isn't working correctly?

Yes. I just described it in https://github.com/jazzband/django-analytical/pull/226#pullrequestreview-1408576409.

bittner avatar May 02 '23 08:05 bittner