odata-v4-mongodb icon indicating copy to clipboard operation
odata-v4-mongodb copied to clipboard

Published 20 hours ago • verified publisher icon jaystack

Fix for Equals Expression and tolower OData function

Open marekkajda opened this issue 6 years ago • 2 comments

Hi,

We are using you module and it works great, but recent changes implemented by another extensions broke it and we have implemented 2 fixes:

  • Parsing correctly filter like: not (documentStatus eq 'OPEN'), current version parsing it to: documentStatus: not 'OPEN'
  • handling tolower OData function

marekkajda avatar Jan 25 '19 11:01 marekkajda

Thanks for the PR @marekkajda! Sorry for the delay. It seems like this would best be served with two PRs since the toLower seems much safer a change than the equality change though they both look good.

What do you mean "recent changes implemented by another extensions broke it"?

Sorry for being pedantic but I was only recently added to this project and am not sure of the scope.

Overall these changes look good however so I hope to move this along this week.

aaghevli avatar Mar 13 '19 17:03 aaghevli

I added some hopefully simple requests for updates if you wish to merge these. Thanks again!

aaghevli avatar Mar 13 '19 17:03 aaghevli