openjdk-jfx icon indicating copy to clipboard operation
openjdk-jfx copied to clipboard

WIP: JDK-8186429 FXMLLoader setStaticLoad should be public API

Open abhinayagarwal opened this issue 7 years ago • 3 comments
trafficstars

This is useful for SceneBuilder to open FXML files with event handler attributes. Currently, SceneBuilder for JDK 9+ uses reflection as a workaround.

abhinayagarwal avatar Mar 26 '18 20:03 abhinayagarwal

There is already a webrev in the issue with potential fix. Does it make this PR redundant?

abhinayagarwal avatar Mar 26 '18 20:03 abhinayagarwal

The static load mode is also helpful if you want to use the FXMLLoader more as a parser. For example, we use it to verify that each fxml file in our project can be parsed successfully (as a unit test), and to extract all localized strings. In these cases, the static load mode is needed.

tobiasdiez avatar May 07 '19 19:05 tobiasdiez

As announced in this message, the official jfx repository is moving from hg.openjdk.java.net/openjfx/jfx-dev/rt to github.com/openjdk/jfx.

This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed.

Once you have done this, it would be helpful to add a comment with a pointer to the new PR.

NOTE: since this is a feature / enhancement request it needs to be discussed on the openjfx-dev mailing list if you want it to be considered.


The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this.

kevinrushforth avatar Oct 01 '19 00:10 kevinrushforth