openjdk-jfx icon indicating copy to clipboard operation
openjdk-jfx copied to clipboard

Published 20 hours ago • verified publisher icon javafxports

WIP: 8206253: Problem with scoll events in window mode

Open michael-p-89 opened this issue 7 years ago • 6 comments
trafficstars

For the scroll events you must use the x and y points not the absX and absY points. If the application is in fullscreen it works with absX and absY, because then x and absX and y and absY is the same. But when you are in window mode the scene.sceneListener.scrollEvent methods are called with wrong x and y points.

michael-p-89 avatar Jun 18 '18 11:06 michael-p-89

There are a few steps missing before we can consider this PR. Please read CONTRIBUTING.md, specifically the sections about filing a bug, and signing the OCA. Also, please provide a unit test or an evaluation of why a unit test is not possible and what alternative testing is needed.

kevinrushforth avatar Jun 26 '18 23:06 kevinrushforth

I have signed the OCA and mailed it to Oracle. I have created a bug with the internal review ID : 9055817 I don't think that unit tests are neccessary, because obviously methods are called with wrong parameters.

michael-p-89 avatar Jun 28 '18 13:06 michael-p-89

I have signed the OCA and mailed it to Oracle.

OK, we will wait until it has been recorded.

As for a test, even for code that is obviously wrong we need some (manual if necessary) set of steps to reproduce the problem before we will accept a patch.

kevinrushforth avatar Jun 29 '18 13:06 kevinrushforth

I have tested this under Linux, but I think it should be the same on Windows:

  1. You need a touch input screen
  2. Create a sample application with any kind of pane as parent for the scene, where the width of the scene should be less than the half of the screen width and the height should be less than the half of the screen height
  3. Add a listener to the pane for the scroll event, and write something on System.out or do anything else
  4. Start the application and move it to the right lower corner of the screen
  5. If you do a scroll in the application no scroll events are received
  6. Move the application to left upper corner of the screen
  7. If you do a scroll in the application scroll events are received (because then the absolute and relative x and y points are the same)

michael-p-89 avatar Jul 02 '18 08:07 michael-p-89

This bug is now in the JBS as JDK-8206253

kevinrushforth avatar Jul 03 '18 20:07 kevinrushforth

As announced in this message, the official jfx repository is moving from hg.openjdk.java.net/openjfx/jfx-dev/rt to github.com/openjdk/jfx.

This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed.

Once you have done this, it would be helpful to add a comment with a pointer to the new PR.

The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this.

kevinrushforth avatar Oct 01 '19 00:10 kevinrushforth