Lyu, Wei-Da

Results 257 comments of Lyu, Wei-Da

There isn't a public API for it. Our code structure is quite different from volar. There isn't a language-service package to be reused. You might have to do more work...

This seems to be an upstream issue with vscode. I am debugging the implementation in vscode. When the code is pasted, It'll check if the position is another language embedded...

I am not saying this has to do with TypeScript. I am only taking TypeScript as an example. Auto indent is not provided by extension, It is core editor functionality....

I can only think of a hacky workaround for it. It's similar to a component import quick fix workaround we have. https://github.com/sveltejs/language-tools/blob/3e7c986c8596da013ef72b139512575cf08be4b2/packages/language-server/src/plugins/typescript/features/CodeActionsProvider.ts#L384 instead of triggering the completion at the real...

It would be possible but the performance would not be great either. This would cause TypeScript to rebuild twice.

We might need a reproducible for this one. The error is thrown by typescript as shown in the error stack. Typescript's codebase is very complex. Without a reproducible, it's really...

I guess I have found a reproducible. Can you check if you have the `"typescript.preferences.importModuleSpecifierEnding": "js",` or `"javacript.preferences.importModuleSpecifierEnding": "js",` config?

It's also possible that the "typescript.preferences.importModuleSpecifierEnding" config is set to `auto` but there's an existing import in the file that imported with a js file extension like `import {} from...

The snippet problem is because we currently associated the moustache with typescript. And it would be quite hard for it to be js or ts depending on script lang because...

Seems like it'll need at least one whitespace after the snippet. Because the `}` is not treated as ts/js anymore. Not sure what we can do here. This is unfortunately...