Lyu, Wei-Da

Results 291 comments of Lyu, Wei-Da

@sebwib These are unrelated issues. The formatting should be https://github.com/sveltejs/language-tools/issues/2426. As for the Quick fix and import problem, please open a separate issue with reproduction.

This would need support from upstream vscode-css-languageservice which pulls data from MDN. And MDN also doesn't have a dedicated page for these geometry properties.

Seems like it was filtered out because of the browser: none. Judging from the generation script, I think that file is from an old source, and they merged it with...

Oh, wait. I saw you linked the MDN page for the CSS property in the upstream issue. So MDN actually added the page recently. I didn't check it before I...

`filePathsToIgnore` is the internal name for the `--ignore` option. Yeah. it predated the "load the tsconfig". We could probably just remove the ability for it to be a glob pattern...

svelte-preprocess is used as a fallback when there isn't a preprocess config or config can't be loaded so I think this would be a breaking change. One example is that...

> I'm wondering why we're having this dependency at all and are not bundling with the other packages. It might be because of the dynamic import in `svelte-preprocess`. `svelte-language-sever` is...

It actually should be a devDependencies because it's bundled by rollup. But It can also be removed as part of https://github.com/sveltejs/language-tools/issues/2364 since fast-glob doesn't handle it.

Found one problem. Although we didn't mention the `--ignore` option can be a glob in the doc. But because it is directly passed to fast-glob, it can be. https://github.com/sveltejs/language-tools/blob/b49270391d22d6d1cd12f6a473d4b3b4cc6f3787/packages/svelte-check/src/index.ts#L35 Not...

This is because there isn't a preprocess config defined. I am not sure if it makes sense if @sveltejs/enhanced-img should expose the preprocessor or if we should add simplify one...