Jason Ish

> > So we should be looking at a fix that is outside of DNS and generic to all unidirectional transactions? > > I think so indeed Have you looked...

> Just reverted the culprit commit as premature optimisation. > > To keep it optimized, I think you need to implement a trait for unidirectional transaction to tell its direction....

> * revert the optimization (is it really helpful ?) Its not an optimization, but instead fixes a real issue. Of course, 2 years ago we weren't reliable at putting...

So this issue only affects the master-6.0.x branch so shouldn't be considered against master. Its more of a if you don't deal with this now, things might break for you...

I think my comment from Aug 2021 still stands (https://github.com/OISF/suricata/pull/6284#pullrequestreview-740004082) > I think this is good now. The extra output is nice. I'd like to hear from @victorjulien if it...

Some initial thoughts: - It uses the "geoip" keyword which is also used by GeoIP2.. While not a big issue I think this means that configure.ac should only allow one....

> Thank you for taking some time to look at this. > > > Some initial thoughts: > > > > * It uses the "geoip" keyword which is also...

@mtremer Any plans to support cities? Also, is there any info on how locations are acquired?

> Is there anything else that needs to be done to get this finally merged so that I can combine things into one job, please? I think now it comes...

Internally EveBox works on UTC, however, its the display logic in the JavaScript that unconditinally converts it to local time. I'll look into a client-side setting to change this. For...