Jason Ish

> Is there a redmine ticket for this ? Do now: https://redmine.openinfosecfoundation.org/issues/6288

> revert of temporary [14ab9aa](https://github.com/OISF/suricata/commit/14ab9aa763d44dda0f4c831047966b595f5630c1) cc @jasonish what was the purpose of this commit ? To revert back to previous rustc behavior to get it my PRs to pass qa.

Replaced by https://github.com/OISF/suricata/pull/8824.

It does. I was working yesterday on the assumption it built on 1.32 or something. I was looking at the wrong page, and obviously didn't test.

Yes, sorry about this. Got dropped, from the frontend only while migrating libraries. I'll bring it back as it all the support is still there on the backend.

I'm traveling all next week so it probably won't be til the week after. Anyways, this feedback is very valuable as I had always questioned, the value of comments and...

Fixed, will be in 0.19.0.

cc @amirabell

Note that clang-format is going to want to reformat every file since source file that was moved from `src/` to `libsuricata/`. I wasn't thinking about that at first, but might...

Latest work over here: https://github.com/OISF/suricata/pull/10802