findroid icon indicating copy to clipboard operation
findroid copied to clipboard

Published 20 hours ago • verified publisher icon jarnedemeulemeester

feat: 10.10 Media segments

Open Cd16d opened this issue 1 year ago • 1 comments

[!WARNING] The old Intro Skipper integration has been removed. The Intro Skipper plugin supports the new MediaSegmentsApi only on Jellyfin 10.10 or higher.

Add

  • Jellyfin 10.10 MediaSegments support

  • Auto Skip toggle

  • Auto Skip options (Mobile only):

    • only in pip
    • always (default on TV)

  • Skip to the next episode if there's no post credit scene

  • Show the skip buttons for a specified duration in seconds

  • Decide which types of segments should display a skip button or enable auto-skip.

  • AndroidTV skip button

  • AndroidTV auto skip

Issues

Closes #851 Closes #834 Fix #833 Closes #931

Cd16d avatar Nov 11 '24 11:11 Cd16d

It would be huge if this gets merged

Matix-Media avatar Nov 16 '24 15:11 Matix-Media

@Cd16d Hi, thanks a lot for keeping this updated with the Compose rework. It is greatly appreciated!

Could you split of the new preference components and related code into a seperate PR? It is easier to review and merge smaller PRs than big ones. :slightly_smiling_face: The preferences code should be reviewed and merged first. After that I will review and merge this PR.

The plan is to merge everything before the next release.

jarnedemeulemeester avatar Jul 18 '25 14:07 jarnedemeulemeester

Hi @jarnedemeulemeester, I've created a new pull request (#1019) for the Multi Select Preference. Looking forward to the next release! 🚀

Cd16d avatar Jul 20 '25 23:07 Cd16d

@Cd16d I have merged the Multi Select Preference PR. Once this PR has been updated to use the new preference components I will review it. 🙂

jarnedemeulemeester avatar Aug 09 '25 13:08 jarnedemeulemeester

I've tested the changes, and they should work. The integration of the button with Android TV is basic, but it functions properly.

Cd16d avatar Aug 14 '25 17:08 Cd16d

I made a few changes:

  • Added a database migration
  • Moved the segments retrieval to the PlayerActivityViewModel instead of while preparing the items.
  • Push the skip button text string resource with the player UiState.
  • Made some stuff non nullable.
  • Some refactoring.

I believe this is ready to merge now!

jarnedemeulemeester avatar Aug 26 '25 17:08 jarnedemeulemeester

Fixed an issue where the button remained visible in the layout. Ready to merge!

Cd16d avatar Aug 26 '25 21:08 Cd16d