findroid icon indicating copy to clipboard operation
findroid copied to clipboard

Published 20 hours ago • verified publisher icon jarnedemeulemeester

feat: Quick Play

Open Natanel-Shitrit opened this issue 2 years ago • 7 comments

Feature Preview

Home Fragment

https://github.com/jarnedemeulemeester/findroid/assets/65548905/2f3f1635-c003-4149-9237-9ab85d84a9fb

TODO:

  • [X] Implement in HomeFragment for "Continue Watching" / "Next Up".
  • [x] Implement in HomeFragment for "Latest <Library Name>". (starts latest unwatched episode / starts movie)
  • [x] Implement in ShowFragment for "Next Up".
  • [x] Implement in ShowFragment for "Season" (starts latest unwatched episode).
  • [x] Implement in SeasonFragment for episodes.
  • [x] Implement in CollectionFragment for items.
  • [x] Implement in DownloadsFragment for items.
  • [x] Implement in FavoriteFragment for items.
  • [x] Implement in SearchResultFragment for items.
  • [x] Implement in LibraryFragment for items.
  • [x] Add error popup when failing to play item.
  • [x] Indicate to the user the item is loading somehow.

Related Issues

  • N/A

Natanel-Shitrit avatar Sep 29 '23 11:09 Natanel-Shitrit

Ready for review :) @jarnedemeulemeester Any ideas for the last 2 TODOs?

Natanel-Shitrit avatar Sep 29 '23 21:09 Natanel-Shitrit

https://github.com/jarnedemeulemeester/findroid/pull/531#issuecomment-1741492002

Any ideas for the last 2 TODOs?

Well, for the loading display, you could show a spinner in the middle of the clicked component, like for example, a spinner in the middle of the show banner like shown below image

and for the error popup you could use a snackbar. Reference: https://m3.material.io/components/snackbar/overview

Matix-Media avatar Sep 29 '23 22:09 Matix-Media

#531 (comment)

Any ideas for the last 2 TODOs?

Well, for the loading display, you could show a spinner in the middle of the clicked component, like for example, a spinner in the middle of the show banner like shown below image

and for the error popup you could use a snackbar. Reference: https://m3.material.io/components/snackbar/overview

I've added a loading indicator, I just don't have a clue how to trigger it from the fragment 😄 I'll try to find a solution but help is much appreciated!

Natanel-Shitrit avatar Oct 01 '23 19:10 Natanel-Shitrit

yeah got no clue either, sorry

Matix-Media avatar Oct 01 '23 21:10 Matix-Media

I'm ditching the per-item loading, for now, it's just triggering the page loading indicator. If anyone willing to help implement the per-item loading indicator feel free to contact me :)

Natanel-Shitrit avatar Oct 02 '23 14:10 Natanel-Shitrit

Finally ready for review 😄 Added error snackbar! image

Natanel-Shitrit avatar Oct 02 '23 16:10 Natanel-Shitrit

RIP

Natanel-Shitrit avatar Dec 30 '23 22:12 Natanel-Shitrit