passport-openidconnect icon indicating copy to clipboard operation
passport-openidconnect copied to clipboard

Published 20 hours ago • verified publisher icon jaredhanson

add PKCE support

Open aaronpk opened this issue 1 year ago • 7 comments

enable with pkce: true when creating the strategy.

Closes #83 and #56

aaronpk avatar Feb 06 '24 22:02 aaronpk

Great job, thank you!!

kamronbatman avatar Feb 06 '24 22:02 kamronbatman

Great job! @kamronbatman We need this feature as well, can we please merge and publish? Thanks

darknightdev avatar Feb 14 '24 19:02 darknightdev

Waiting on @jaredhanson to validate, add tests, and determine if there are any breaking changes. It sounds silly but many people rely on this. If I get time next week I'll work with him on tests.

kamronbatman avatar Feb 14 '24 19:02 kamronbatman

I tested this further. The call back on the backend doesn't pass the code challenge with it so it errors out.

MattPaymentus avatar Feb 26 '24 18:02 MattPaymentus

@MattPaymentus not sure what you mean, I have this code working against an authorization server that requires PKCE.

aaronpk avatar Feb 26 '24 19:02 aaronpk