passport-local icon indicating copy to clipboard operation
passport-local copied to clipboard

Remove mention of non-existent "session" option

Open JamesMGreene opened this issue 9 years ago • 5 comments
trafficstars

The README makes some references to an option called "session" that were added in commit https://github.com/jaredhanson/passport-local/commit/06d290bf07c5cfcff1ef72cba8edc93bc6ca9cbc

The codebase does not contain any such option today, nor did it at the time of that commit (i.e. if you look at https://github.com/jaredhanson/passport-local/tree/06d290bf07c5cfcff1ef72cba8edc93bc6ca9cbc ).

This was confusing for me... probably for others as well.

JamesMGreene avatar Dec 02 '15 21:12 JamesMGreene

Agree @JamesMGreene came here just to check if session exist in the code

weblancaster avatar Jan 12 '16 18:01 weblancaster

@jaredhanson I ran into this issue as well. Any chance to merge this PR?

micmro avatar Jun 08 '17 01:06 micmro

ping @jaredhanson

kafein avatar Jun 26 '17 19:06 kafein

Merged in https://github.com/passport-next/passport-local

rwky avatar Jul 07 '18 14:07 rwky

I too was really confused by the session-option in the documentation. @jaredhanson is it possible to merge this into the main-library? Or is it perhaps recommended to adopt the usage of passport-next where this fix was merged?

gunhaxxor avatar Jun 22 '21 14:06 gunhaxxor