image_processing
image_processing copied to clipboard
janko
allow resize_to_fill to skip cropping #74
Adds the ability to pass crop: false to MiniMagick#resize_to_fill per #74
Unfortunately, I could not figure out a way to make this to work the same on the vips side.
Looks like libvips isn't available on the travis servers. Do I need to do something special to get the build working again?
@janko is there anything I can do to fix the build and get this back on track? My apologies if I'm missing something, I have not directly sent a PR before.
Thanks for the pull request, and sorry for letting it fall off my radar. On master I've migrated from Travis CI to GitHub CI, so that should be passing once this branch is updated.
In general I agree the option of this kind of resizing should be there, and after some consideration I think I agree with overloading #resize_to_fill. We'll just need to do the same thing for the vips backend for consistency, and also update the documentation.
Just noticed that we both tacked the same problem. I managed to get it to work in both IM and VIPS but I created a seperate method cover: https://github.com/janko/image_processing/pull/75
