jan icon indicating copy to clipboard operation
jan copied to clipboard

Bring social media links

Open Gri-ffin opened this issue 1 year ago • 1 comments

fixes #1273

I brought back the GitHub and Twitter link back, as for discord, for some reason lucid doesn't have a dedicated discord icon, so I didn't know which Icon I should replace it with, if the team can tell me I would gladly add the icon mentioned.

as for opening the social media links, it seemed cumbersome to me to login every time the new electron window is open, so I open the link in the default browser of the user, if this is not how it should go, I can revert it back.

here is a quick demo:

https://github.com/janhq/jan/assets/82527700/475f68ea-f673-46d4-a7ae-74064bbfefba

Gri-ffin avatar Jan 02 '24 13:01 Gri-ffin

Thanks for this - this is awesome!

@imtuyethan what do you think about the icon placement? Do you have an existing design somewhere that shows how socials can be integrated into ribbon/footbar, etc?

freelerobot avatar Jan 02 '24 13:01 freelerobot

Hi @Gri-ffin thank you so much for bringing this up! Great idea! FYI, I'll change the design a little bit to match Jan's style

hantran-co avatar Jan 03 '24 09:01 hantran-co

Of course

Gri-ffin avatar Jan 03 '24 09:01 Gri-ffin

@Gri-ffin here's the updated design for this: https://github.com/janhq/jan/issues/1315, thanks @Gri-ffin

hantran-co avatar Jan 03 '24 11:01 hantran-co