feat: model.json doesn't have any required params

[freelerobot]

Problem Per spec, users should only have to modify 1 field for a model to work

source_url: //techincally, the only required field

Success Criteria A clear and concise description of what you want to happen.

• Have a global default for model.json
• Maybe just a fallback via /model-extensions/src/model.json
• Maybe design a future compatible name i.e. /model-extension/src/gguf-model.json

Additional context

Once this is the case, this issue would be a breeze: https://github.com/janhq/jan/issues/678

[namchuai]

Hmm, let's say user import the model locally, which is drag and drop to Jan. Then, source_url might not be relevant, right?

[freelerobot]

Hmm, let's say user import the model locally, which is drag and drop to Jan. Then, source_url might not be relevant, right?

I think we still have to think about this from the perspective of technical users who directly mv & edit files.

Then what is absolutely required for models to run - it should be as little fields required as possible.

One option is a global model.json file in /models that specifies the default values of a model.json. It is used as a fallback when individual model.jsons haven't defined certain fields. This also makes it clear to users what the default model settings are.

Open to a more elegant solution here. I really dont know.

Scenarios:

• User has 1 model binary, but has 2 configurations, e.g. folders model-a-with-params-a and model-a-with-params-b. It doesnt make sense for users to create copies of large model binaries. In this case source_url: ../../model-a/model.gguf would be neat.
• User decides they want all downloaded models to have max_tokens: 2048 (or some other global default preference), in this case, they'd only have to edit the default model.json once, instead of editing every single model.json in every model download folder. (In fact, the individual model.jsons can be quite sparse)

Happy to chat/debate about this further tomorrow! cc @dan-jan @hiro-v (who were in original discussions about this)

[freelerobot]

Update, for RAG /files, we decided to copy over each file upload directly into /thread-id folder.

[freelerobot]

woot

On Thu, Jan 4, 2024 at 5:50 PM NamH @.***> wrote:

Closed #1028 https://github.com/janhq/jan/issues/1028 as completed via #1314 https://github.com/janhq/jan/pull/1314.

— Reply to this email directly, view it on GitHub https://github.com/janhq/jan/issues/1028#event-11387654373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQVWFCHPSABEZR6ZHHHBVQDYMZ3PJAVCNFSM6AAAAABAV5YVGGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGM4DONRVGQZTOMY . You are receiving this because you authored the thread.Message ID: @.***>