magic-trace icon indicating copy to clipboard operation
magic-trace copied to clipboard

Published 20 hours ago • verified publisher icon janestreet

Filter events from after the stop indicator

Open cgaebel opened this issue 3 years ago • 2 comments

Magic-trace doesn't stop recording exactly when the stop indicator is hit. That can be quite confusing, especially if you get unlucky and the stop event is nowhere near the right hand side of the trace.

To fix this, let's filter out events from the trace that happen after the stop indicator returns.

It's conceivable that people will want the current behavior behind a flag, but I weakly think it's not worth the extra UI complexity.

cgaebel avatar Mar 27 '22 15:03 cgaebel

Looks like this could be useful: search man perf-record for "tracestop". I think it might end up as a message in the perf script, so if we use this we'll need to filter that message out.

cgaebel avatar Apr 17 '22 15:04 cgaebel

Ref also -immediate-stop from https://github.com/janestreet/magic-trace/pull/79.

Xyene avatar Apr 17 '22 20:04 Xyene