magic-trace icon indicating copy to clipboard operation
magic-trace copied to clipboard

Allow sharing traces via `MAGIC_TRACE_SHARE_COMMAND`

Open Xyene opened this issue 3 years ago • 3 comments

Tested with MAGIC_TRACE_SHARE_COMMAND=/usr/bin/echo.

Also fixed a bug where we were unconditionally serving the UI if the Perfetto base dir was specified. We lose port configurability, but it's not a big deal and we can add it back as a separate flag if we want to.

Xyene avatar Apr 08 '22 17:04 Xyene

Port configurability is a big deal! We all use the same machine at work to do magic-trace stuff. That said, I'm fine with adding it back in a separate feature.

cgaebel avatar Apr 08 '22 18:04 cgaebel

I'm not sure which I like more:

  • a -serve-port flag, or
  • starting from 8080 and trying increasing port numbers until we find one we can bind to

Xyene avatar Apr 08 '22 18:04 Xyene

My heart says (2, but start at 1024), but my brain says (1). S'up to you.

cgaebel avatar Apr 08 '22 18:04 cgaebel