mst-async-storage icon indicating copy to clipboard operation
mst-async-storage copied to clipboard

Incorporate package updates and also add onSave/onLoad

Open djMax opened this issue 3 years ago • 4 comments
trafficstars

As mentioned in #21

djMax avatar Feb 12 '22 19:02 djMax

the native module is not loading properly in a version of this branch. Looking into why. I think it's a require/default/import problem.

djMax avatar Feb 14 '22 01:02 djMax

@djMax Let me know if/when this is ready to merge and I'll get a release cut.

jamonholmgren avatar Feb 17 '22 17:02 jamonholmgren

So I don't know whether the use of the RN async storage module should be done with require or import. In our app, import is required. So I would assume that it's required here too, but @markrickert 's PR didn't have it I don't think. Do you know something other than experimental evidence that would tell us which to use? :)

djMax avatar Feb 17 '22 17:02 djMax

I don't know as much as I'd like about configuring metro, but maybe playing with the transform inlineRequires would solve the issue.

markrickert avatar Feb 17 '22 18:02 markrickert