James Please

Results 314 comments of James Please

That's awesome that you found a workaround! I'm glad our API supports that use case. However, I'm not too satisfied with it. It seems a little messier than I'd like....

We could [add an outline](https://jsfiddle.net/3fvqggut/) to prevent any regressions in behavior. Edit: box shadow could work, too!

Another idea – and this would be an ambitious project – is an interactive ‘schema,’ like what’s in the README. Imagine if the website had a GUI where you could...

Related: https://github.com/brigade/react-waypoint/issues/155#issuecomment-281749975 (and that whole thread). In that thread, it was decided, at the time, that this lib didn't need such a callback. The more I think about it, though,...

After reading that article, and a few other ones on the topic, this _seems_ right to me. But I'll also defer to @lencioni .

Not a bad idea, but we may lose some backwards compatibility. If there’s no way to add a fallback for the current behavior, we will want to think about when...

Fragments were added in React 16.2, and Waypoint supports versions older than that right now, so it would be breaking.

One idea is: ```jsx {showWaypoint && } ``` `showWaypoint` could be a value stored within component state. You can then set the state, and the waypoint will mount and i...

That’s great that you were able to achieve what you were trying to do. I can see why you might prefer a declarative solution over the imperative one that you’re...