James Please

Results 314 comments of James Please

Gonna wait until https://github.com/babel/generator-babel-boilerplate/issues/319 is done

Hey there @jreeter . I'm not opposed to adding something like this, but someone else would need to code it up with tests and make a PR. If you're up...

update: it looks like React Router v6's `Router` component will remove the `history` prop. What are the implications of this change for libs like `qhistory` / `query-history`? Will it be...

React Composer was just updated. Please let me know if there are still issues that can be resolved through updates to that library.

> Argh, I feel dumb. Putting the forward slash in front of it works. Thanks for the help - is there something that could be done to make both work...

**Update:** Oops, this was me being silly. I forgot to properly configure the `basename` in the Router itself. Totally my fault. Once I did that, everything worked perfectly. Btw, for...

> I guess, I need to add this to documentation, because it is easy to mess up this. Would you like for me to create a PR? (By the way,...

> Network error adding a contributor. This should differentiate different types of network errors, I think, such as no connection and rate limiting.

From a comment over in #47 : Many contributions don't involve GitHub issues, so I don't think this makes sense as the default behavior. The problem with going with this...

> But it's kinda hard to automate that. Trade-offs with the amount of time we have to work on this. :+1: makes sense. > If you want to change it...