jamesob

Results 133 comments of jamesob

I think this is ready for "actual" review, in case anyone was wondering.

Can someone rerun the windows job? Now that I'm not a member of the org, I can't kick CI Jobs.

Ready for a re-review when you're ready, @tdb3 @rkrux.

Tests passing, ready for re-review. I think we're close on this one.

@achow101 ready for merge?

Pushed a [small fix](https://github.com/bitcoin/bitcoin/compare/1ca5f7b998c14c44b6afd5e362fc4c007d8eebd3..0667ee2e5bbaba1d2965ab95644bdb27f881ffa1) addressing `blockhash` nullability.

+1, this would be huge. Willing to take a crack at implementing.

crACK https://github.com/bitcoin/bitcoin/pull/32415/commits/b5f580c580257d28d295cae3f787b55eb1863f16 Scripted-diff/func-test-only makes this an easy review. Good cleanup for this daunting file.

I've added a link to the active [Delving Bitcoin discussion](https://delvingbitcoin.org/t/ctv-csfs-can-we-reach-consensus-on-a-first-step-towards-covenants/1509/23) most pertaining to CTV, and will keep the PR description above updated with any other relevant discussions.