James Kermode
James Kermode
Thank you for the contribution. As you will have seen there are failures in the regression tests so this can't yet be merged. Are you working on fixing the failing...
Yup, I'll take a look. It seems there are now some conflicts, if you are willing to try to resolve them that would speed things up.
I'm just going from the GitHub warning above about conflicts. Rebasing on current master should solve it.
Thank you - I will merge providing the CI tests pass.
@smiet and/or @zhucaoxiang there are some remaining test failures I am afraid - would you be willing to take a further look?
You'll first need to update this branch from master to bring in the changes
Still failing tests I'm afraid
Thanks very much! I have also reviewed the substantive changes and am in principal very happy to accept this contribution. The only thing that gives me a pause for thought...
Yes. I will go ahead and merge this then do a PyPI release. Thanks everyone for the work!
Looks to be related to https://github.com/mesonbuild/meson/issues/12399